Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Plugin for Pug #6245

Closed
Shinigami92 opened this issue Jun 23, 2019 · 12 comments
Closed

Introducing Plugin for Pug #6245

Shinigami92 opened this issue Jun 23, 2019 · 12 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@Shinigami92
Copy link
Member

referencing issues #5767 and #4686

@ispyhumanfly, @j-f1, @RDhar, @danielpza, @lydell
Hello at all 馃槂
I'm happy to introduce the plugin for prettier to support pug! 馃帀
https://github.com/Shinigami92/prettier-plugin-pug

I'm currently in heavily development phase and I am not completely finished with the base yet.
But I would like to let you know that I would like to publish a first alpha in the next few days.
In addition, I am currently developing so that no options can be passed. I'll do that later if the base is stable.

If you want to test something, you're welcome to help me.

@RDhar
Copy link

RDhar commented Jun 23, 2019

Brilliant, that's great to hear! 馃帀

Do keep us in the loop with how you're getting along and we'd be more than happy to test/help out wherever possible.

And a huge thanks for taking on this challenge in the first place!

@alexander-akait
Copy link
Member

alexander-akait commented Jun 24, 2019

Feel free to send a PR in docs 馃憤 I think community help to improve this plugin 馃憤

@Shinigami92
Copy link
Member Author

I'm happy to announce the first alpha :D

Please create issues for any bugs

https://github.com/Shinigami92/prettier-plugin-pug/releases/tag/1.0.0-alpha.1

https://www.npmjs.com/package/prettier-plugin-pug

@Shinigami92
Copy link
Member Author

Shinigami92 commented Jun 26, 2019

I have published an alpha.2
I used npm publish --tag aplha and I think the --tag was wrong, so it's not seen as the latest version 馃
Nevermind, Changelog

Thanks to @RDhar, I used your repo for some internal testing 馃槃

Edit:
I used npm dist-tag add prettier-plugin-pug@1.0.0-alpha.2 latest and now it's fixed

@RDhar
Copy link

RDhar commented Jun 26, 2019

It's great to hear that some use came of that repo! I'd meant to keep it updated as a standard baseline for my smaller web projects in the future. But, would you believe it, due to an issue with Parcel's CSS-loader, template-pug was left behind and forgotten(!)

Will be sure to pick this up shortly. Is there any additional steps on getting up and running with it on VS Code?

@Shinigami92
Copy link
Member Author

Shinigami92 commented Jun 26, 2019

Yes, follow this PR: prettier/prettier-vscode#757

Have not tested it this way yet. If it does not work, just use yarn prettier --write "**/*.pug"

@lipis
Copy link
Member

lipis commented Jun 28, 2019

As already mentioned.. please add it to the this list: https://prettier.io/docs/en/plugins.html#community-plugins

@Shinigami92
Copy link
Member Author

@lipis #6246 is already merged 馃

@lipis
Copy link
Member

lipis commented Jun 28, 2019

So I guess we can close it now! https://twitter.com/PrettierCode/status/1144718891349938177?s=19

@lipis lipis closed this as completed Jun 28, 2019
@lipis
Copy link
Member

lipis commented Jun 28, 2019

we can also move it under prettier to make it official since it's v1

@Shinigami92
Copy link
Member Author

1.0.0-alpha.7 is released and supports wrapping of attributes 馃帀
Road to rc.1? 馃憖

@Shinigami92
Copy link
Member Author

I just released 1.0.0 馃帀

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

4 participants