Making a release with new options / 1.19.0 “post mortem”

[lydell]

All options in Prettier have a since: "x.y.z" field.

The new option in 1.19, vueIndentScriptAndStyle, had since: "1.19.0".

prettier --support-info apparently does not print stuff with a higher since version than is specified in package.json.

The release script bumps the version in package.json and then runs the tests. The tests for prettier --support-info then fail, because now it returns the new option added in 1.19.0 which isn’t in the snapshots.

I worked around this issue by first making a commit where I bumped the version in package.json to 1.19.0-beta.1 and updated the snapshots:

057e15d

However, we now have this in our code:

vueIndentScriptAndStyle: {
    since: "1.19.0-beta.1",

The questions of this issue are:

• Is since: "1.19.0-beta.1" a problem? EDIT: Changed to since: "1.19.0" in 1.19.1.
• Does the release script need updating to handle new options?
• Should the PR adding the new vueIndentScriptAndStyle have done something differently?

@duailibe do you have any insight?

[duailibe]

@lydell If I understand correctly, what's missing in the release script is to change package.json version back to "NEXTVERSION-dev". Does that make sense?

[lydell]

Another way would be to default version in getSupportInfo(version, opts) to "999.9.9" rather than require("../../package.json").version.split("-", 1)[0] I guess. Or something like that – not passing a version should mean “give me everything”. One should ideally not have to update the snapshots when bumping the version.

[fisker]

Is this still a problem? There will be a new option in v2.1

[thorn0]

No longer a problem. The version in package.json is already set to 2.1.0-dev, so the snapshots don't change after changing it to 2.1.0. The problem with 1.19.0 was that the version in package.json wasn't set to 1.19.0-dev after releasing 1.18.2. No idea why. The release script should have done that.