Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parentheses of sequence expressions breaks code #7490

Closed
fisker opened this issue Jan 30, 2020 · 5 comments
Closed

Remove parentheses of sequence expressions breaks code #7490

fisker opened this issue Jan 30, 2020 · 5 comments
Labels
lang:javascript Issues affecting JS locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program

Comments

@fisker
Copy link
Member

fisker commented Jan 30, 2020

Prettier 1.19.1
Playground link

--parser babel

Input:

export default (1, 2);

Output:

export default 1, 2;

Second Output:

SyntaxError: Unexpected token, expected ";" (1:17)
> 1 | export default 1, 2;
    |                 ^
  2 | 

Expected behavior:

A case found in #7470

@armano2
Copy link
Contributor

armano2 commented Jan 30, 2020

note: this issue is present in babel, jest and typescript, and its related to estree/estree#193

@thorn0 thorn0 added lang:javascript Issues affecting JS type:bug Issues identifying ugly output, or a defect in the program labels Jan 30, 2020
@alexander-akait
Copy link
Member

Fixed in next

@thorn0
Copy link
Member

thorn0 commented Jan 31, 2020

Are issues not closed automatically because PRs target next, not master, or is GitHub broken?

@alexander-akait
Copy link
Member

Honestly, I do not know, maybe this really only works for the master, need to write in support

@thorn0
Copy link
Member

thorn0 commented Jan 31, 2020

I wrote yesterday, No answer so far.

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang:javascript Issues affecting JS locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Development

No branches or pull requests

4 participants