Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier would insert --- for first line comment with --- #8378

Closed
chnldw opened this issue May 21, 2020 · 0 comments · Fixed by #8386
Closed

Prettier would insert --- for first line comment with --- #8378

chnldw opened this issue May 21, 2020 · 0 comments · Fixed by #8386
Labels
lang:yaml Issues affecting YAML locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program

Comments

@chnldw
Copy link

chnldw commented May 21, 2020

Prettier 2.0.5
Playground link

--parser yaml

Input:

# --- comments ---

Output:

--- # --- comments ---

Expected behavior:
keep it as comments

# --- comments ---
@thorn0 thorn0 added lang:yaml Issues affecting YAML type:bug Issues identifying ugly output, or a defect in the program labels May 22, 2020
@fisker fisker mentioned this issue May 24, 2020
Closed
fisker added a commit to fisker/prettier that referenced this issue May 24, 2020
@fisker
Test prettier#8378
f9868c0
@fisker fisker mentioned this issue May 24, 2020
Merged
4 tasks
fisker added a commit to fisker/prettier that referenced this issue May 24, 2020
@fisker
Test prettier#8378
3a4f5b1
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
lang:yaml Issues affecting YAML locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update yaml-unist-parser to v1.2.1 fisker/prettier
2 participants
@thorn0 @chnldw