Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return printing #866

Closed
cpojer opened this issue Mar 3, 2017 · 1 comment
Closed

return printing #866

cpojer opened this issue Mar 3, 2017 · 1 comment
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. status:needs discussion Issues needing discussion and a decision to be made before action can be taken

Comments

@cpojer
Copy link

cpojer commented Mar 3, 2017 •
edited by vjeux

Currently return statements are printed like this:

return a &&
  b;

however, there is another option, like this:

return (
  a &&
  b
);

which lines up the expressions a bit better and is similar to if-statements. Any chance we could change this?
@vjeux vjeux added the status:needs discussion Issues needing discussion and a decision to be made before action can be taken label Mar 3, 2017
@vjeux vjeux mentioned this issue Mar 3, 2017
Closed
vjeux added a commit to vjeux/prettier that referenced this issue Mar 3, 2017
@vjeux
Add parens around return for binaryish expressions
9aade5a 
It looks better when the first element is aligned with the rest and this is consistent with the way we render `if` test.

Fixes prettier#866
@vjeux vjeux mentioned this issue Mar 3, 2017
Merged
@vjeux
Copy link
Contributor

vjeux commented Mar 3, 2017

I think it's a good idea, sent #870 to implement it.

vjeux added a commit to vjeux/prettier that referenced this issue Mar 19, 2017
@vjeux
Add parens around return for binaryish expressions
11486ec 
It looks better when the first element is aligned with the rest and this is consistent with the way we render `if` test.

Fixes prettier#866
vjeux added a commit that referenced this issue Mar 19, 2017
@vjeux
Add parens around return for binaryish expressions (#870)
c749ddd 
It looks better when the first element is aligned with the rest and this is consistent with the way we render `if` test.

Fixes #866
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. status:needs discussion Issues needing discussion and a decision to be made before action can be taken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpojer @vjeux