Use fs.promises in build script #10025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Jan 8, 2021
| @@ -1,7 +1,7 @@ | |||
| "use strict"; | |||
|
|
|||
| const path = require("path"); | |||
| const fs = require("fs"); | |||
| const fs = require("fs").promises; | |||
There was a problem hiding this comment.
Is require('fs/promises') prefered?
There was a problem hiding this comment.
fs/promises is only supported on Node.js 14 and above
sosukesuzuki
force-pushed
the
use-fs-promises
branch
from
643853c
to
e82e971
Compare
fisker
approved these changes
Jan 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use fs.promises in build script.
Checklist
✨Try the playground for this PR✨