Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix pre-commit hook setup command #10710

Merged
merged 1 commit into from May 9, 2021
Merged

[Docs] Fix pre-commit hook setup command #10710

merged 1 commit into from May 9, 2021

Conversation

bokub
Copy link
Contributor

@bokub bokub commented Apr 15, 2021

Description

In the provided example, pretty-quick is installed locally, not globally, which may cause the hook to fail:

❯ git commit
.husky/pre-commit: 4: pretty-quick: not found
husky - pre-commit hook exited with code 127 (error)

This problem can be fixed by running "npx pretty-quick --staged" instead of just "pretty-quick --staged"

Maybe @typicode can confirm?


N.B I've made changes to documentation only, so everything below is not applicable

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

thorn0
thorn0 approved these changes Apr 21, 2021
Copy link
Member

@thorn0 thorn0 left a comment

@thorn0 thorn0 merged commit 7cfa9aa into prettier:main May 9, 2021
26 checks passed
@bokub bokub deleted the patch-1 branch May 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants