New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate jsxBracketSameLine option in favour of multi-language bracketSameLine option #11006
Deprecate jsxBracketSameLine option in favour of multi-language bracketSameLine option #11006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep old options (include CLI) for compatibility, just log deprecation
1535e19
to
cd2f9b7
Compare
@fisker is there anything else I need to do before this PR can be accepted? |
f058c56
to
10ab0c8
Compare
I reverted unnecessary changes, and wrote some new tests. |
Can you fix tests? |
@fisker tests are fixed, I ended up just having to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One comment about test.
I'm not good at docs, we'll need other maintainers to approve.
description: "Put > on the last line instead of at a new line.", | ||
deprecated: "2.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had test for deprecated options before, can we add one for this? Check https://github.com/prettier/prettier/pull/7536/files, the old tests_integration/__tests__/arg-parsing.js
file is moved to tests/integration/__tests__/arg-parsing.js
exactly what i was looking for! would love to use this feature, looking forward for the release kudos kurtztech ✨ |
Looking forward for the release. May I asked about the possible release time? |
Waiting for this ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should not include updating markdown files under /website/versioned_docs/version-stable/
. It should be updated when we release 2.4.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix problems above and I think we can merge it
So is it just the markdown file changes I need to remove, or are there other issues? |
@kurtztech Please check a comment from @fisker. You need to add more tests for deprecated options. (#11006 (comment)) |
Co-authored-by: fisker Cheung <lionkay@gmail.com>
a93a579
to
3190b9e
Compare
Great job! 👍🏻 |
The option name is super generic ... #5377 (comment). Too late to change that now I suppose. |
Description
I've added a new option
bracketSameLine
that was approved to address issue #5377, essentially making a generic version of thejsxBracketSameLine
option that works for HTML, JSX, Vue, and Angular. I've deprecatedjsxBracketSameLine
. It still works, but it is now listed as deprecated in the docs and CLI, and has been removed from the playground options.Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨