Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Update remark parser 9 #11938

Closed

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Dec 7, 2021

Description

WORK IN PROGRESS.

#11867 is good. However, we cannot use pure ESM in our source code yet. So we should do update remark without using ESM.

  • Update remark-parse to v9 (NOT v10)
  • Don't update unified (Need to do in the future, but not in this PR)
  • Rewrite our unified plugins to support new plugin system
  • Use helpful external plugins

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@sosukesuzuki
Copy link
Member Author

sosukesuzuki commented Dec 7, 2021

current test status (under ./tests/format/markdown):

Test Suites: 20 failed, 22 passed, 42 total
Tests:       159 failed, 426 passed, 585 total
Snapshots:   159 failed, 426 passed, 585 total

@fisker
Copy link
Member

fisker commented Dec 7, 2021

Great work.

Note: The tests in tests/format/markdown/auto-link/jsfmt.spec.js not all valid.

@sosukesuzuki
Copy link
Member Author

It is hard to update unified and remark-parse without breaking changes. So close this. I reopen the PR that has a same purpose of this PR based on next branch.

@sosukesuzuki sosukesuzuki deleted the update-remark-parser-9 branch March 27, 2022 10:24
@fisker fisker mentioned this pull request Apr 24, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants