Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Simplify printSequence() #12535

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Refactor: Simplify printSequence() #12535

merged 2 commits into from
Mar 31, 2022

Conversation

fisker
Copy link
Member

@fisker fisker commented Mar 25, 2022

Description

Found it when reviewing #12519, path.call() not obvious it returns an array.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker marked this pull request as ready for review March 25, 2022 09:23
@fisker fisker closed this Mar 26, 2022
@fisker
Copy link
Member Author

fisker commented Mar 26, 2022

Close and reopen to trigger CI, it.should fail after merge #12519, I'll fix later.

@fisker fisker reopened this Mar 26, 2022
@fisker fisker merged commit b40a5d0 into prettier:main Mar 31, 2022
@fisker fisker deleted the graphql branch March 31, 2022 13:04
sosukesuzuki pushed a commit that referenced this pull request Apr 2, 2022
sosukesuzuki pushed a commit that referenced this pull request Apr 2, 2022
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 3, 2024
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants