no-semi comments #1257
Merged
no-semi comments #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeux
added a commit
to vjeux/prettier
that referenced
this pull request
Apr 14, 2017
In prettier#1257, I discovered that if there's a `""` doc at the end, it's not going to trim the previous one correctly. It also happens to fix a few existing things.
vjeux
commented
Apr 14, 2017
| @@ -1112,7 +1112,7 @@ switch (node && node.type) { | |||
| case "MethodDefinition": | |||
| prop = node.key; | |||
| break; | |||
|
|
|||
There was a problem hiding this comment.
This will be fixed by #1259
vjeux
commented
Apr 14, 2017
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| let error = new Error(response.statusText) | ||
| // comment | ||
| ;(error: any).response = response |
vjeux
added a commit
that referenced
this pull request
Apr 14, 2017
In #1257, I discovered that if there's a `""` doc at the end, it's not going to trim the previous one correctly. It also happens to fix a few existing things.
It doesn't yet work but I think it's close
rattrayalex
reviewed
Apr 14, 2017
|
No, it's not going to work but I can't find any real-world use case where it would be an issue. Can you think of one? |
|
Thanks, that's helpful. I don't think it's high priority but I'll think
about it...
…On Thu, Apr 13, 2017, 19:31 Christopher Chedeau ***@***.***> wrote:
No, it's not going to work but I can't find any real-world use case where
it would be an issue. Can you think of one?
I can make up examples though:
https://prettier.github.io/prettier/#%7B%22content%22%3A%22%3B(%5Cn%20%20%2F%2F%20a%5Cn%20%201%20-%201)%20*%2010%5Cn%22%2C%22options%22%3A%7B%22printWidth%22%3A80%2C%22tabWidth%22%3A2%2C%22singleQuote%22%3Afalse%2C%22trailingComma%22%3A%22all%22%2C%22bracketSpacing%22%3Atrue%2C%22jsxBracketSameLine%22%3Afalse%2C%22parser%22%3A%22babylon%22%2C%22semi%22%3Afalse%2C%22useTabs%22%3Afalse%2C%22doc%22%3Afalse%7D%7D
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1257 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAq_LgqwJhqYslDHBqZAPibL9d9ex_6Lks5rvtp_gaJpZM4M9Utg>
.
|
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245