Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async parser #12748

Merged
merged 25 commits into from May 4, 2022
Merged

Support async parser #12748

merged 25 commits into from May 4, 2022

Conversation

fisker
Copy link
Member

@fisker fisker commented Apr 29, 2022

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker
Copy link
Member Author

fisker commented Apr 29, 2022

Only problem here: I can't simply make parse return a Promise, embed parser have to be sync.

Options:

  1. Don't support async parser in embed format.
  2. Support async printer.print() (maybe jest printer.embed() function is enough ), I was not planning to support async printer, there are some known issues in doc

Personally I prefer 1.

@kachkaev @sosukesuzuki WDYT?

@fisker
Copy link
Member Author

fisker commented Apr 29, 2022

Anyway, I'm not going to implement embed support in this PR. We can discuss in other issue #12751 .

@fisker fisker changed the title [WIP] Support async parser Support async parser Apr 29, 2022
@fisker fisker marked this pull request as ready for review April 29, 2022 09:58
@fisker fisker merged commit e14411c into prettier:next May 4, 2022
@fisker fisker deleted the async-parser branch May 4, 2022 03:15
@fisker fisker mentioned this pull request Jul 19, 2022
4 tasks
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant