Try searching for manually specified plugins in pluginSearchDir's

[zachkirsch]

Description

If you specify a --plugin that lives outside the current tree (i.e. not resolvable by require.resolve), the CLI throws with a MODULE_NOT_FOUND error. Locations provided via --plugin-search-dir are not searched.

After this PR: Locations provided via --plugin-search-dir are searched when resolving manually specified plugins.

Checklist

• I’ve added tests to confirm my change works.
• (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
• (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
• I’ve read the contributing guidelines.

✨Try the playground for this PR✨

[fisker]

pluginSearchDirs and plugins are independent and one does not require the other.

https://prettier.io/docs/en/plugins.html#using-plugins

[zachkirsch]

Thanks for taking a look @fisker and @kachkaev! While pluginSearchDirs and plugins don't require each other, this PR is addressing the case where you choose to use both.

In the link you sent, the first example is

prettier --write main.foo --plugin-search-dir=./dir-with-plugins --plugin=prettier-plugin-foo

i.e. using a plugin prettier-plugin-foo that exists in ./dir-with-plugins.

However, if you instead specified a path that doesn't fall inside the current workspace, then prettier fails:

prettier --write main.foo --plugin-search-dir=../../../../dir-with-plugins --plugin=prettier-plugin-foo

If you checkout the first commit on this branch 9f8329d (it includes the test but not the fix) you can see an example

[fisker]

You can do prettier --plugin=../../../../dir-with-plugins/prettier-plugin-foo/index.js

[zachkirsch]

Yep that’s true! Just kind of cumbersome if I have a lot of plugins that live in that directory.

Would you rather this PR not merge? I thought I was fixing a bug but it sounds like the existing behavior is preferable?

[fisker]

Close sinc the plugin search feature has been removed.