New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove prettier.doc.builders.concat
#13203
Conversation
Should we remove it "softly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update commands.md
and add changelog?
# Conflicts: # src/language-html/printer-html.js
Yes, let's do this. |
Otherwise for many plugins it might be the only breaking change. With this soft deprecation, there is a good change those plugins won't need to be changed at all. |
Should we change this line prettier/src/document/constants.js Line 2 in e096ea7
to anther string? Otherwise, {
type: 'concat'
} Will pass the doc type check, but fail when calling array methods. |
Let's use "array". |
Description
Ref #13142
Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨