Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prettier.doc.builders.concat #13203

Merged
merged 13 commits into from Aug 6, 2022
Merged

Conversation

fisker
Copy link
Member

@fisker fisker commented Aug 1, 2022

Description

Ref #13142

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker mentioned this pull request Aug 1, 2022
23 tasks
@fisker
Copy link
Member Author

fisker commented Aug 1, 2022

Should we remove it "softly" const concat = parts => parts?

@fisker fisker marked this pull request as ready for review August 1, 2022 14:10
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update commands.md and add changelog?

@fisker fisker requested a review from thorn0 August 3, 2022 10:32
@fisker
Copy link
Member Author

fisker commented Aug 5, 2022

@thorn0 #13203 (comment)

@thorn0
Copy link
Member

thorn0 commented Aug 5, 2022

Should we remove it "softly" const concat = parts => parts?

Yes, let's do this.

@thorn0
Copy link
Member

thorn0 commented Aug 5, 2022

Otherwise for many plugins it might be the only breaking change. With this soft deprecation, there is a good change those plugins won't need to be changed at all.

@fisker
Copy link
Member Author

fisker commented Aug 5, 2022

Should we change this line

export const DOC_TYPE_CONCAT = "concat";

to anther string?

Otherwise,

{
	type: 'concat'
}

Will pass the doc type check, but fail when calling array methods.

@thorn0
Copy link
Member

thorn0 commented Aug 5, 2022

Let's use "array".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants