Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for custom parser api #13250

Merged
merged 7 commits into from Aug 7, 2022
Merged

Conversation

fisker
Copy link
Member

@fisker fisker commented Aug 7, 2022

Description

Fix #13232

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

docs/api.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
thorn0 and others added 2 commits August 7, 2022 13:49
Co-authored-by: fisker Cheung <lionkay@gmail.com>
@fisker fisker marked this pull request as ready for review August 7, 2022 11:30
@fisker fisker merged commit 0b9cb96 into prettier:next Aug 7, 2022
@fisker fisker deleted the remove-parser branch August 7, 2022 17:09
@fisker fisker mentioned this pull request Aug 7, 2022
expect(output).toBe("bar();\n");
});

test("parsers should allow omit optional arguments", async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No wonder I can't find this test.... it's removed. We still need it.

medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 18, 2024
Co-authored-by: fisker Cheung <lionkay@gmail.com>
Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants