add printer branch for TSFirstTypeNode #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
despairblue
changed the title
|
Could you also add a snapshot test along with it? This way it's easier to review and is a good regression test. Thanks! |
|
@vjeux done |
|
Awesome, thanks a lot! |
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the printer implementation for the
TSFirstTypeNode. I'm not sure this is correct, since I callpath.getParentNode()in theTypeAnnotationbranch but instead of getting the direct parent (which would beTSFirstTypeNode) I actually get the parent's parent, thus I have to walk down that path one node again.When looking for the parent node it probably just skips unknown nodes. I'll take a look at
path.getParentNode's implementation later this week.