Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 blog post #13436

Merged
merged 22 commits into from
Jul 5, 2023
Merged

V3 blog post #13436

merged 22 commits into from
Jul 5, 2023

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Sep 6, 2022 •
edited by thorn0

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@sosukesuzuki sosukesuzuki mentioned this pull request Sep 27, 2022
Closed
23 tasks
@thorn0
Copy link
Member

thorn0 commented Oct 9, 2022

I think we don't need a separate PR for the post. We can do this directly in the next branch (#9583).

@thorn0
Copy link
Member

thorn0 commented Oct 9, 2022

On the other hand, regenerating and recomitting the blog post file directly to next every time sucks. I wish that file generated when website builds.

@sosukesuzuki
Copy link
Member Author

I think we don't need a separate PR for the post. We can do this directly in the next branch (#9583).

@thorn0 Is it difficult to review code if we push to next directly?

@thorn0
Copy link
Member

thorn0 commented Oct 11, 2022

I meant this PR is convenient for previewing the blog post on the web. But you have a good point, it's also convenient for reviewing.

@fisker
Copy link
Member

fisker commented Mar 25, 2023 •
edited

I noticed people leaving this line in changelog.

prettier/changelog_unreleased/TEMPLATE.md

Line 27 in dd779da

<!-- Optional description if it makes sense. -->

Can you fix this check? It only checks the first comment.

prettier/scripts/lint-changelog.mjs

Lines 97 to 101 in dd779da

if (content.includes(templateComment)) {
showErrorMessage(
`[${displayPath}]: Please remove template comments at top.`
);
}

eg: https://github.com/prettier/prettier/pull/14573/files#diff-71b1a378b04cabd879ec44b91b3b8314e8c8016f76f9e18291897bc4b34d87c1R3

Please also clean up existing comments in /CHANGELOG.md and blog posts if there are.

@sosukesuzuki sosukesuzuki mentioned this pull request Mar 27, 2023
Merged
2 tasks
@sosukesuzuki sosukesuzuki changed the base branch from next to main March 27, 2023 13:26
@sosukesuzuki sosukesuzuki marked this pull request as ready for review March 28, 2023 13:37
@thorn0
Copy link
Member

thorn0 commented Mar 30, 2023

Both "Prettier stable" and "Prettier main" get replaced with "Prettier 3.0":
image

@sosukesuzuki sosukesuzuki mentioned this pull request Mar 31, 2023
Merged
4 tasks
@kachkaev kachkaev added this to the 3.0 milestone Apr 4, 2023
sosukesuzuki
sosukesuzuki commented Apr 20, 2023
View reviewed changes
changelog_unreleased/blog-post-intro.md

We have made the migration to using ECMAScript Modules for all our source code. This change has significantly improved the development experience for the Prettier team. Please rest assured that when using Prettier as a library, you can still use it as CommonJS as well.

This update comes with several breaking changes. One notable example is the alteration in markdown formatting - spaces are no longer inserted between Latin characters and Chinese or Japanese characters. We'd like to extend our gratitude to [Tatsunori Uchino](https://github.com/tats-u), who has made significant contributions to Prettier over the past year, particularly with this feature. Additionally, the default value of `trailingComma` has been changed to `"all"`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tats-u We greatly appreciate your contribution in improving the formatting of Markdown. So we would like to put your name at the top of the Prettier v3 release blog, is that okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sosukesuzuki Sorry for very late reply. There's no problem to post my name.

@sosukesuzuki sosukesuzuki mentioned this pull request Jun 11, 2023
Closed
kachkaev
kachkaev approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@kachkaev kachkaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

tats-u
tats-u approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@tats-u tats-u left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I disagreed with this PR even though I just approved using my name in https://github.com/prettier/prettier/pull/13436/files#r1225763298. I'll unify our reviews' status with ✔ by changing mine from 💬.

@sosukesuzuki sosukesuzuki merged commit c9d62c0 into prettier:main Jul 5, 2023
27 checks passed
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 15, 2024
@sosukesuzuki @medikoo
V3 blog post (prettier#13436)
c92aa12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisker fisker fisker approved these changes

@kachkaev kachkaev kachkaev approved these changes

@tats-u tats-u tats-u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sosukesuzuki @thorn0 @fisker @kachkaev @tats-u