Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @angular/compiler to v14 #13609

Merged
merged 10 commits into from Oct 11, 2022
Merged

Update @angular/compiler to v14 #13609

merged 10 commits into from Oct 11, 2022

Conversation

fisker
Copy link
Member

@fisker fisker commented Oct 10, 2022 •
edited

Description

Fixes #11204

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review October 10, 2022 10:56
@fisker fisker mentioned this pull request Oct 10, 2022
Closed
4 tasks
thorn0
thorn0 reviewed Oct 10, 2022
View reviewed changes
cspell.json Outdated
@@ -279,6 +280,7 @@
"Rubocop",
"ruleset",
"rulesets",
"runable",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's "runnable".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fisker
Copy link
Member Author

fisker commented Oct 10, 2022

Forgot to remove NGQuotedExpression related logic, will fix tomorrow.

@fisker fisker marked this pull request as draft October 10, 2022 15:26
@fisker fisker marked this pull request as ready for review October 11, 2022 03:25
@fisker fisker merged commit 3ca842d into prettier:next Oct 11, 2022
@fisker fisker deleted the angular-14 branch October 11, 2022 03:26
@fisker fisker mentioned this pull request Jan 11, 2023
Closed
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 5, 2024
@fisker @medikoo
Update @angular/compiler to v14 (prettier#13609)
1e1ab1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorn0 thorn0 thorn0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @thorn0