Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow: Print trailing comma in type parameters when --trailing-comma=es5 #14085

Merged
merged 7 commits into from Feb 9, 2023
Merged

Flow: Print trailing comma in type parameters when --trailing-comma=es5 #14085

merged 7 commits into from Feb 9, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Dec 30, 2022 •
edited

Description

Fixes #3722
Closes #6198

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker changed the title Print trailing comma in type parameters when --trailing-comma=es5 Flow: Print trailing comma in type parameters when --trailing-comma=es5 Dec 30, 2022
@fisker fisker marked this pull request as ready for review January 3, 2023 03:35
@sosukesuzuki sosukesuzuki self-requested a review February 8, 2023 10:30
@fisker fisker merged commit 62827ab into prettier:next Feb 9, 2023
@fisker fisker deleted the type-parameters branch February 9, 2023 02:01
This was referenced Feb 9, 2023
Closed
Closed
@kachkaev kachkaev mentioned this pull request Jul 23, 2023
Closed
@sosukesuzuki sosukesuzuki mentioned this pull request Oct 27, 2023
Merged
2 tasks
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 8, 2024
@fisker @medikoo
Flow: Print trailing comma in type parameters when `--trailing-comma=…
5b45484 
…es5` (prettier#14085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sosukesuzuki