Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor tracking inside JSXText #14163

Merged
merged 10 commits into from Apr 10, 2023
Merged

Fix cursor tracking inside JSXText #14163

merged 10 commits into from Apr 10, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Jan 12, 2023

Description

Fixes #13986

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker marked this pull request as ready for review January 12, 2023 10:55
@fisker fisker changed the title Fix cusor tracking inside JSXText Fix cursor tracking inside JSXText Jan 14, 2023
# Conflicts:
#	src/language-js/print/jsx.js
@fisker fisker added this to the 3.0 milestone Mar 28, 2023
@fisker fisker merged commit bec997e into prettier:main Apr 10, 2023
25 of 26 checks passed
@fisker fisker deleted the 13986 branch April 10, 2023 02:44
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong cursorOffset with formatted JSX text
1 participant