Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite TypeAnnotation and TSTypeAnnotation print #14171

Merged
merged 30 commits into from Jan 28, 2023
Merged

Rewrite TypeAnnotation and TSTypeAnnotation print #14171

merged 30 commits into from Jan 28, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Jan 13, 2023

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker

This comment was marked as outdated.

Sign in to view
@fisker fisker closed this Jan 13, 2023
@fisker fisker deleted the type-annotation branch January 13, 2023 04:47
@fisker fisker restored the type-annotation branch January 13, 2023 07:53
@fisker fisker reopened this Jan 13, 2023
@fisker fisker changed the title Rename printTypeAnnotation to printTypeAnnotationProperty Rewrite TypeAnnotation and TSTypeAnnotation print Jan 13, 2023
@fisker
Copy link
Member Author

fisker commented Jan 13, 2023 •
edited

@Gregoor I've rewrite the TSTypeAnnotation print, should fix #12491 now (tests not added yet).

@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
@fisker fisker marked this pull request as ready for review January 13, 2023 09:13
@fisker fisker marked this pull request as draft January 16, 2023 11:56
fisker and others added 2 commits January 17, 2023 10:36
@fisker @thorn0
Update src/language-js/print/type-annotation.js
af65908 
Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>
@fisker
Add type to CommentCheckFlags
567d901
@fisker fisker marked this pull request as ready for review January 17, 2023 05:09
@fisker fisker mentioned this pull request Jan 17, 2023
Draft
4 tasks
@fisker fisker merged commit 627c9a7 into prettier:next Jan 28, 2023
@fisker fisker deleted the type-annotation branch January 28, 2023 01:27
@fisker fisker mentioned this pull request Jan 28, 2023
Closed
@fisker fisker mentioned this pull request Apr 18, 2023
Merged
1 task
@fisker fisker mentioned this pull request Aug 28, 2023
Open
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 7, 2024
@fisker @thorn0 @medikoo
Rewrite TypeAnnotation and TSTypeAnnotation print (prettier#14171)
d78b366 
Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorn0 thorn0 thorn0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @thorn0