Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript-eslint to v6 #14429

Merged
merged 50 commits into from Jul 21, 2023
Merged

Conversation

fisker
Copy link
Member

@fisker fisker commented Mar 1, 2023

Description

  • Remove our invalid AST check.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker force-pushed the typescript-eslint-6 branch 3 times, most recently from 42b4c20 to f667b30 Compare March 1, 2023 07:38
@fisker fisker force-pushed the typescript-eslint-6 branch 2 times, most recently from f2ae57a to 4f52a3c Compare March 9, 2023 03:24
fisker added 13 commits March 9, 2023 11:30
# Conflicts:
#	package.json
#	tests/format/misc/errors/typescript/modifiers/__snapshots__/jsfmt.spec.js.snap
#	yarn.lock
# Conflicts:
#	package.json
#	yarn.lock
# Conflicts:
#	package.json
#	src/language-js/parse/postprocess/index.js
#	yarn.lock
@fisker fisker marked this pull request as ready for review June 19, 2023 14:59
@fisker fisker marked this pull request as draft June 19, 2023 15:01
# Conflicts:
#	package.json
#	scripts/build/config.js
#	src/language-js/parse/postprocess/index.js
#	src/language-js/parse/postprocess/typescript.js
#	src/language-js/parse/typescript.js
#	src/language-js/print/object.js
#	yarn.lock
@sosukesuzuki
Copy link
Member

@fisker Thank you for working on this! Just a question, why can we remove our invalid AST node process? It is now done in typescript-estree?

@fisker
Copy link
Member Author

fisker commented Jul 21, 2023

Yes, they lives in typescript-estree now. https://github.com/typescript-eslint/typescript-eslint/commits?author=fisker

@fisker fisker merged commit 12fd889 into prettier:main Jul 21, 2023
31 checks passed
@fisker fisker deleted the typescript-eslint-6 branch July 21, 2023 18:35
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants