Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract code from postcss printer #14480

Merged
merged 7 commits into from
Mar 20, 2023
Merged

Extract code from postcss printer #14480

merged 7 commits into from
Mar 20, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Mar 10, 2023 •
edited

Description

I want to make some change to the value-comma_group part, but it's too long, let extract to a separate file.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as draft March 10, 2023 08:09
@fisker fisker changed the title Extract printValueCommaGroup Extract printCommaSeparatedValueGroup Mar 10, 2023
@fisker fisker changed the title Extract printCommaSeparatedValueGroup Extract code from postcss printer Mar 10, 2023
@fisker fisker marked this pull request as ready for review March 11, 2023 07:42
sosukesuzuki
sosukesuzuki previously approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we should extract this part too, thanks!

@fisker fisker dismissed sosukesuzuki’s stale review March 13, 2023 05:07

Extracted more code, but forgot to push on friday.

@fisker fisker merged commit 5b80d29 into prettier:next Mar 20, 2023
@fisker fisker deleted the printValueCommaGroup branch March 20, 2023 00:24
@seiyab seiyab mentioned this pull request Mar 30, 2023
Merged
4 tasks
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 13, 2024
@fisker @medikoo
Extract code from postcss printer (prettier#14480)
68b9d7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sosukesuzuki