Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop insert unnessary leading semicolon in vue event binding #14557

Merged
merged 7 commits into from Mar 27, 2023
Merged

Stop insert unnessary leading semicolon in vue event binding #14557

merged 7 commits into from Mar 27, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Mar 22, 2023 •
edited

Description

Also did a major refactor to ExpressionStatement print to make the logic easier to understand.

Actually change is one line 05cbb80#diff-05721d38b1e893fb67bc43a716ba53373414de083d82d17852170b5dc3bf75e1L10

Fixes #9060

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review March 22, 2023 09:26
@fisker fisker merged commit 3c7e217 into prettier:next Mar 27, 2023
28 checks passed
@fisker fisker deleted the expression-statement branch March 27, 2023 05:37
@fisker fisker mentioned this pull request Mar 27, 2023
Closed
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 13, 2024
@fisker @medikoo
Stop insert unnessary leading semicolon in vue event binding (prettie…
21f119f 
…r#14557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fisker