Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new line after { detection in TSMappedType #14659

Merged
merged 7 commits into from Apr 10, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Apr 3, 2023

Description

Ref: #14619 (comment)

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker
Copy link
Member Author

fisker commented Apr 3, 2023

@sosukesuzuki You added this in #6146, did you mean to detect new line after {?

@fisker fisker changed the title Fix new line after { detect in TSMappedType Improve new line after { detect in TSMappedType Apr 3, 2023
@fisker fisker marked this pull request as ready for review April 3, 2023 10:47
@fisker fisker changed the title Improve new line after { detect in TSMappedType Improve new line after { detection in TSMappedType Apr 3, 2023
# Conflicts:
#	src/language-js/print/typescript.js
@sosukesuzuki
Copy link
Member

You added this in #6146, did you mean to detect new line after {?

I don't remember because it was almost four years ago, but maybe yes.

@fisker fisker merged commit 1e50206 into prettier:main Apr 10, 2023
29 checks passed
@fisker fisker deleted the mapped-type-break branch April 10, 2023 01:56
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants