Bundle actual cjs entry #14746
Closed
Bundle actual cjs entry #14746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Bundling CJS in parallel to ESM can help us with prettier/prettier-vscode#2947, but will significantly increase package download size for everyone. A CJS bundle will probably be incompatible with Prettier plugins using ESM. I feel like we need to seek for a solution on the VS Code side, probably as suggested by @sosukesuzuki in prettier/prettier-vscode#2947 (comment). |
|
Closing since it didn't work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VSCode extention can't use cjs proxy to
import()esm version, try to bundle CommonJS version of index.cjsChecklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨