New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove space after pipe name #14961
Remove space after pipe name #14961
Conversation
| pipeA | ||
: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not this for consistency?
| pipeA | |
: { | |
| pipeA: | |
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just rolled back how prettier treated the first semicolon. I guess this is how it used to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waterplea Thank you for this PR. I've updated the changelog. I'm not familiar with Angular and its community, so I trust you.
@sosukesuzuki Can this be ported into v2? |
* Remove space after pipe name * Add changelog * Update changelog * Update changelog --------- Co-authored-by: Sosuke Suzuki <sosuke.suzuki@dr-ubie.com>
Description
As per discussion in the linked issue, the most desired format was to keep spaces around semicolon separating pipe arguments, but remove space after pipe name.
Closes #13887
Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨