[DO NOT MERGE] Do not add / to HTML void tags #15021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanKingston
force-pushed
the
jkt/html-void-tag
branch
from
913198f
to
b120f20
Compare
jonathanKingston
force-pushed
the
jkt/html-void-tag
branch
from
b120f20
to
4ea5310
Compare
jonathanKingston
force-pushed
the
jkt/html-void-tag
branch
from
4ea5310
to
60213ca
Compare
|
You can mark this pull request as draft if it is not ready for review. |
|
@jonathanKingston great job! I'm applying this code by using patch-package, which is working properly for what I noticed. |
|
The issue (#5246) was reported 5 years ago and the PR was submitted already. The code provides what is requested as something optional, not mandatory. Can someone take a look at this please? |
|
@fisker @sosukesuzuki @thorn0 please? |
|
@brdillin they won't do anything, similar tools are doing this but they won't do anything no matter what, simple as that (#5246). However, we are lucky because a modern developer recently designed a plugin for this https://github.com/awmottaz/prettier-plugin-void-html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rebase/rewrite of #8628 by @fisker to resolve #5246 as there is renewed interest by @jakearchibald see: https://twitter.com/jaffathecake/status/1676843832284004353
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨