Add support for Vue "Generic Components" #15066
Conversation
| textToDoc, | ||
| { | ||
| parser: "babel-ts", | ||
| __isVueScriptGeneric: true, |
There was a problem hiding this comment.
Do you think we should use a better name for this flag? Plugins like prettier-plugin-pug may use it in future, we'll not able to change it.
There was a problem hiding this comment.
Sounds good, something like __isEmbeddedTypescriptGenericParameters?
There was a problem hiding this comment.
I pushed this change. Maybe then we should rename printVueScriptGenericAttributeValue? Because it doesn't contain vue-specific logic. And I guess if somebody in future will use __isEmbeddedTypescriptGenericParameters, he probably will be required to duplicate at least this statement
return formatAttributeValue(
`type T<${value}> = any`,
textToDoc,
{
parser: "babel-ts",
__isEmbeddedTypescriptGenericParameters: true,
},
shouldHugJsExpression,
);There was a problem hiding this comment.
This file is internal, we can rename it anytime we want, but I'll be fine if you want to rename it.
There was a problem hiding this comment.
Okay, if we can rename it after, this is fine! Let's leave it as it is. If I need to fix anything else, let me know :)
| @@ -0,0 +1,24 @@ | |||
| #### Add support for Vue "Generic Components" (#15066 by @auvred) | |||
|
|
|||
There was a problem hiding this comment.
Can you add the link to https://blog.vuejs.org/posts/vue-3-3#generic-components ?
* add support for vue generic components * add changelog and remove duplicated test case * refactor * rename file + simplify isVueScriptTag usage * __isVueScriptGeneric -> __isEmbeddedTypescriptGenericParameters * add link to blog post to changelog
Description
Closes #14864
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨