Support as and satisfies expressions for Flow

[gkz]

Description

Adds support for printing as and satisfies expressions in Flow.

const x = y as T;

This is accomplished first by factoring out TypeScript's logic and using/extending that.

Tests are mostly copied from TS's tests. I did a diff of Flow's and TS's snapshot file to confirm that that differences were expected (from input change).

Checklist

• I’ve added tests to confirm my change works.
• (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
• I’ve read the contributing guidelines.

✨Try the playground for this PR✨

[gkz]

Does anyone have an idea why "Prod / Node.js 18 on ubuntu-latest (Full Test) (pull_request)" (and only that) is failing?
Running the tests locally passes

[fisker]

FULL_TEST=1 yarn test tests/format/flow/as-satisfies-expression/jsfmt.spec.js

[thorn0]

The names isTypeExpression and printCastExpression are inconsistent and also both aren't really good names. How about isBinaryCastExpression/printBinaryCastExpression?

[gkz]

The names isTypeExpression and printCastExpression are inconsistent and also both aren't really good names. How about isBinaryCastExpression/printBinaryCastExpression?

All casts are binary, but you're right it should be isCastExpression & printCastExpression - will update

[fisker]

But there is already a node type called TypeCastExpression.

prettier/src/language-js/print/flow.js

Line 248 in 24dfe5a

case "TypeCastExpression":

[gkz]

But there is already a node type called TypeCastExpression.

You're right, I can call it isBinaryCastExpression . The other one requires parens so isn't like a binary expression.

[gkz]

Sorry for the delay, I went on vacation and when I got back started working on other stuff.
I've updated the PR now as per your latest comment.

[fisker]

#15130 (comment)

[gkz]

I'm used to using Mercurial every day so forgot to add the files before amending!

[fisker]

Do we need a release after merge, or we can wait?

[gkz]

Do we need a release after merge, or we can wait?

I'm not in a rush with this, you don't need to change your release schedule