Do not print trailing commas in arrow function type parameter lists in ts code blocks
#15286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Aug 23, 2023
src/language-markdown/embed.js
Outdated
| // should be printed depends on whether it is `*.ts` or `*.tsx`. | ||
| // https://github.com/prettier/prettier/issues/15282 | ||
| if (node.lang === "ts" || node.lang === "tsx") { | ||
| newOptions.filepath = `dummy.${node.lang}`; |
There was a problem hiding this comment.
How should we print this?
```typescript
const foo = <T>() => {}
```
|
This link is broken, can you fix it? https://typescript-eslint.io/packages/parser/#jsx |
fisker
approved these changes
Aug 24, 2023
fisker
approved these changes
Aug 24, 2023
fisker
reviewed
Aug 24, 2023
|
After second thought, maybe we should pretent it's |
|
If you agree, we should update this line instead |
1 task
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 15, 2024
…n `ts` code blocks (prettier#15286) * Remove trailing comma for `ts` code blocks * Add changelog * Support `typescript` * Update link * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15282
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨