Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deferred import evaluation and source phase import syntax #15487

Merged
merged 19 commits into from Oct 8, 2023

Conversation

sosukesuzuki
Copy link
Member

Description

Context: #15471

Based on: #15486

Supports deferred import evaluation syntax.

Checklist

  • I’ve added tests to confirm my change works.
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@@ -45,6 +46,8 @@ const parseOptions = {
"importReflection",
"explicitResourceManagement",
["importAttributes", { deprecatedAssertSyntax: true }],
Copy link
Sponsor Member

@fisker fisker Oct 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding createImportExpressions, Do we still need deprecatedAssertSyntax?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@sosukesuzuki sosukesuzuki changed the title Support deferred import evaluation syntax Support deferred import evaluation and source phase import syntax Oct 8, 2023
@sosukesuzuki sosukesuzuki marked this pull request as ready for review October 8, 2023 23:38
@sosukesuzuki sosukesuzuki merged commit 4b43249 into prettier:main Oct 8, 2023
28 checks passed
@sosukesuzuki sosukesuzuki deleted the defer-import-eval branch October 8, 2023 23:52
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants