Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed excessive spaces after line prefixes for unordered lists in Markdown #15526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TomasLudvik
Copy link

@TomasLudvik TomasLudvik commented Oct 20, 2023

Description

This change fixes excessive spaces after line prefixes for unordered lists in Markdown. Closes #5019.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@TomasLudvik TomasLudvik changed the title removed excessive spaces after line prefixes for unordered lists in Markdown Removed excessive spaces after line prefixes for unordered lists in Markdown Oct 20, 2023
@TomasLudvik
Copy link
Author

Hello @fisker, what can I do to push this PR forward?

@grossmannmartin
Copy link

Hi,
this seems like a really important fix. What has to be done to push this forward?

@LucasOe
Copy link

LucasOe commented Jan 8, 2024

Any progress on this? I would really like to see this feature!

@glenn-jocher
Copy link

@TomasLudvik @fisker what's the status on this PR? This is the one problem preventing Prettier adoption at our org.

@TomasLudvik
Copy link
Author

@glenn-jocher It is waiting for review from @fisker or @sosukesuzuki as I am not a maintainer of this repo.

@grossmannmartin
Copy link

Hi @fisker, @sosukesuzuki
Any news regarding this issue?

@Lixquid
Copy link

Lixquid commented Apr 4, 2024

Hi @fisker, @sosukesuzuki, I really hate to pester, but this is causing some immense grief with having to manually remove the extra spaces after the markers, is there anything anyone can do to push this forward?

The deviation fights with basically every example and other linting tool out there as shown in a comment in #5019 which makes it a near impossible sell to match the other way round.

@glenn-jocher
Copy link

@fisker @sosukesuzuki please merge this PR as soon as you can without further delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab width should not affect text alignment after the bullet points in Markdown lists
5 participants