Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "json" parser for tsconfig.json by default #16012

Merged
merged 17 commits into from Feb 3, 2024

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Feb 2, 2024

Description

Implement @fisker's proposal (#15956 (comment)).

Closes #15958

Checklist

  • I’ve added tests to confirm my change works.
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@sosukesuzuki sosukesuzuki marked this pull request as ready for review February 2, 2024 18:55
src/utils/infer-parser.js Outdated Show resolved Hide resolved
@fisker fisker changed the title Fix parser inference for JSONC Treat tsconfig.json as JSON file by default Feb 3, 2024
@fisker fisker changed the title Treat tsconfig.json as JSON file by default Treat tsconfig.json files as JSON files by default Feb 3, 2024
@fisker fisker changed the title Treat tsconfig.json files as JSON files by default Use "json" parser for tsconfig.json by default Feb 3, 2024
@fisker fisker merged commit cc6435c into prettier:main Feb 3, 2024
14 of 15 checks passed
wmitsuda added a commit to otterscan/otterscan that referenced this pull request Feb 10, 2024
wmitsuda added a commit to otterscan/otterscan that referenced this pull request Feb 10, 2024
* Bump prettier from 3.2.4 to 3.2.5

Bumps [prettier](https://github.com/prettier/prettier) from 3.2.4 to 3.2.5.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.2.4...3.2.5)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Set tsconfig.json as jsonc by default; prettier/prettier#16012

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Willian Mitsuda <wmitsuda@gmail.com>
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 18, 2024
Co-authored-by: fisker Cheung <lionkay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants