Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic import when the module source is a template literal #16267

Merged
merged 4 commits into from
May 11, 2024
Merged

Fix dynamic import when the module source is a template literal #16267

merged 4 commits into from
May 11, 2024

Conversation

fisker
Copy link
Member

@fisker fisker commented May 8, 2024 •
edited
Loading

Description

Fixes #16266

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review May 8, 2024 07:45
@fisker fisker merged commit 26f1cd9 into prettier:main May 11, 2024
28 checks passed
@fisker fisker deleted the import-template-literal branch May 11, 2024 01:02
@kachkaev kachkaev added this to the 3.3 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kachkaev kachkaev kachkaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

dynamic import keyword is removed when given multiline template string
2 participants
@fisker @kachkaev