New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(support-info): add options
field
#3433
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
637cc3e
refactor: rename supportTable with supportLanguages
ikatyang 976503a
refactor: use `dedent`
ikatyang 644b733
test: reduce unnecessary data
ikatyang e099397
feat(support-info): add `options` field
ikatyang 669db3b
test: snapshot diff
ikatyang f4efee0
fix(support): add missing `since`
ikatyang e883da3
fix: add missing `category`
ikatyang 259f463
refactor: use template tag
ikatyang ffd09e4
fix: `trailingComma:true` should redirect to `trailingComma:es5`
ikatyang e32ac72
refactor: reorder parser
ikatyang 78b7ab9
Merge branch 'master' into feat/support-options
ikatyang 7a36c4d
Merge branch 'master' into feat/support-options
ikatyang 5f404a8
Merge branch 'master' into feat/support-options
duailibe be3ae05
refactor: fix linting
ikatyang 9543207
refactor: move options
ikatyang 31673c1
refactor: move options to printers
ikatyang 5297037
Merge branch 'master' into feat/support-options
ikatyang File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
"use strict"; | ||
|
||
const jsOptions = require("../language-js/options"); | ||
|
||
// format based on https://github.com/prettier/prettier/blob/master/src/common/support.js | ||
module.exports = { | ||
singleQuote: jsOptions.singleQuote | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
"use strict"; | ||
|
||
const jsOptions = require("../language-js/options"); | ||
|
||
// format based on https://github.com/prettier/prettier/blob/master/src/common/support.js | ||
module.exports = { | ||
bracketSpacing: jsOptions.bracketSpacing | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options
should probably be a property of a specific printer rather than a plugin, as a plugin can provide multiple languages/printers. In this case it should beprinters.estree.options