fix(playground): fix report version #3614
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duailibe
approved these changes
Dec 30, 2017
lipis
approved these changes
Dec 30, 2017
j-f1
reviewed
Dec 30, 2017
| @@ -24,7 +24,7 @@ const parserPaths = parsers.map(stripLanguageDirectory); | |||
|
|
|||
| if (isPullRequest) { | |||
| const pkg = require("../../package.json"); | |||
| pkg.prVersion = `pr-${process.env.REVIEW_ID}`; | |||
| pkg.version = `999.999.999-pr.${process.env.REVIEW_ID}`; | |||
There was a problem hiding this comment.
Why not use [current version]-pr.1234?
There was a problem hiding this comment.
I think a version followed by -something is meant to denote pre-releases of a version (which is not the case)
There was a problem hiding this comment.
prettier/src/common/support.js
Lines 12 to 17 in 7eca801
We use this version to determine which language (and option in the future PR) can be used, which means it should be greater than the current version in PR builds so we can test it on the preview playground.
azz
approved these changes
Dec 31, 2017
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #3613 and apply another solution since we don't actually expose
prVersionfromprettiermodule, which cause the wrong version on copy markdown. 😂cc @azz