Do not require plugins to set 'since' field #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikatyang
reviewed
Feb 24, 2018
| @@ -81,10 +81,9 @@ function inferParser(filepath, plugins) { | |||
| pluginsLoaded: true | |||
| }).languages.find( | |||
| language => | |||
| typeof language.since === "string" && | |||
There was a problem hiding this comment.
language.since !== null? We should omit unreleased languages here.
src/common/support.js
Outdated
| return semver.gte(version, language.since); | ||
| } | ||
| return true; | ||
| }) |
There was a problem hiding this comment.
How about
language.since
? semver.gte(version, language.since)
: language.since !== null?
There was a problem hiding this comment.
Yeah I originally had a ternary but it looked messy/hard to reason about so I switched it to if/else.
ikatyang
approved these changes
Feb 24, 2018
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue raised in prettier/plugin-php#55