Report test summaries to CircleCI

[j-f1]

Fixes #4510.

[j-f1]

[lydell]

As far as I can tell this condition is always false. I think you forgot parentheses around \d+:

+process.version.match(/^v(\d+)\./)[1] >= 6

[azz]

Or require('semver').major(process.version) >= 6

[duailibe]

Why not add another conditional?

${process.env.JEST_JUNIT ? "--reporters ..." : ""}

And then just set this env in test_prod_node9

[duailibe]

Is it possible to move this to jest.config.js?

[j-f1]

nope. Is there a way to remove it before publishing?

[duailibe]

Yeah we already modify it in the build script:

prettier/scripts/build/build.js

Lines 77 to 91 in 3f91d64

	async function preparePackage() {
	const pkg = await util.readJson("package.json");
	pkg.bin = "./bin-prettier.js";
	pkg.engines.node = ">=4";
	delete pkg.dependencies;
	delete pkg.devDependencies;
	pkg.scripts = {
	prepublishOnly:
	"node -e \"assert.equal(require('.').version, require('..').version)\""
	};
	pkg.files = ["*.js"];
	await util.writeJson("dist/package.json", pkg);
	await util.copyFile("./README.md", "./dist/README.md");
	}

[hawkrives]

@j-f1 If I'm reading the docs right, the junit config could be put into the "reporters" part of jest.config.js (although Prettier doesn't use that field currently, so it's probably simpler to just remove it as part of the build script.)

[j-f1]

After re-reading the docs, it looks like package.json and environment variables are the only way to configure the package without explicitly enabling it. Putting the config in jest.config.js would cause the package to always be loaded, which would cause issues on older Node versions.

[SimenB]

@palmerj3 is that correct? If so, we should fix it

[j-f1]

@SimenB I meant that if I put the config in the reporters section, that would enable the reporter, which I only want to do on the one test run.

[palmerj3]

That's correct. You can have configuration live in jest.config.js if you want and use the reporter configuration. Most folks have jest-junit loaded as a reporter all the time and just gitignore the junit.xml file since it doesn't add very much overhead at all.

But if you REALLY don't want a junit.xml file generated locally then perhaps use the CI=true environment variable and update your jest.config.js to have a conditional for that.

[SimenB]

reporters: [
  "default",
  process.env.CI ? ["jest-junit", { ...config }] : null,
].filter(Boolean);

or something like that should work, shouldn't it?

[palmerj3]

Yep, exactly.

[SimenB]

this isn't necessary, is it?

[j-f1]

#4859