Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glimmer): preserve empty text attributes #4897

Merged

Conversation

tchak
Copy link
Contributor

@tchak tchak commented Jul 26, 2018

input

<button disabled></button>
<img alt="" />

before

<button disabled></button>
<img alt />

after

<button disabled></button>
<img alt="" />

@tchak tchak force-pushed the fix-glimmer-empty-non-bolean-attributes branch 2 times, most recently from 3fd7f4f to 949e851 Compare July 26, 2018 14:36
@ikatyang
Copy link
Member

ikatyang commented Aug 1, 2018

FYI, glimmer parser is now available on the preview playground.

Prettier pr-4897
Playground link

--parser glimmer

Input:

<button disabled></button>
<img alt="" />

Output:

<button disabled></button><img alt="" />

@duailibe duailibe merged commit 783923a into prettier:master Aug 1, 2018
@ikatyang ikatyang added this to the 1.14.1 milestone Aug 2, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Oct 31, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants