fix(language-js/pragma.js): support pragma in comments #5357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards1211
force-pushed
the
pragma-in-comments
branch
from
7aa9453
to
9c9cb88
Compare
jedwards1211
force-pushed
the
pragma-in-comments
branch
from
9c9cb88
to
ed8e715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5352
Added code to
language-js/pragma.jsthat uses some regex magic to scan through leading single-line or multiline comments in a file (that is, until it reaches something that's not a comment or whitespace) and check if any of those comments contains@prettieror@formatsurrounded by whitespace or line boundaries.EDIT: updated to skip a hashbang on the first line as well.
Thus it's now possible to trigger prettier with
/* @prettier */,// @prettier,/* @flow @prettier */, etc., in addition to the existing support for the pragma inside a docblock.docs/directory)✨Try the playground for this PR✨