Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update yaml parser #5491

Closed
wants to merge 1 commit into from
Closed

chore: update yaml parser #5491

wants to merge 1 commit into from

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Nov 15, 2018 •
edited
Loading

Ref: https://github.com/ikatyang/yaml-unist-parser/blob/master/CHANGELOG.md#100-2018-11-15

Remove the CRLF workaround.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang mentioned this pull request Nov 15, 2018
Merged
2 tasks
@ikatyang ikatyang added the status:wip Pull requests that are a work in progress and should not be merged label Nov 16, 2018
@ikatyang ikatyang mentioned this pull request Nov 21, 2018
Merged
1 task
@ikatyang
Copy link
Member Author

Replaced by #5494.

@ikatyang ikatyang closed this Nov 25, 2018
@ikatyang ikatyang deleted the chore/yaml/update-parser branch November 25, 2018 08:39
@ikatyang ikatyang removed the status:wip Pull requests that are a work in progress and should not be merged label Nov 25, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@lydell lydell lydell approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikatyang @existentialism @lydell