Revert "Print \x and \u escapes in strings and regexes lowercase (#522)" #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttier#522)" This reverts commit 7148184. There are four types of literals where escapes were normalized: 1. Strings ('\xAb' and "\xAb") 2. Regexes (/\xAb/) 3. Untagged template literals (`\xAb`) 4. Tagged template literals (tag`\xAb`) However, changing the case of the escapes alters the runtime behavior of in two of the above cases. ```js /\xAb/.source === '\\xAb' // true String.raw`\xAb` === '\\xAb' // true ``` So for regexes and tagged template literals the escapes must not be changed. Instead of enforcing lowercase escapes in only 50% of the different cases, it was decided not to bother with escapes at all. Closes prettier#562.
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7148184.
There are four types of literals where escapes were normalized:
'\xAb'and"\xAb")/\xAb/)`\xAb`)tag`\xAb`)However, changing the case of the escapes alters the runtime behavior of
in two of the above cases.
So for regexes and tagged template literals the escapes must not be
changed. Instead of enforcing lowercase escapes in only 50% of the
different cases, it was decided not to bother with escapes at all.
Closes #562.