Fix multiline dynamic import comments #6025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4617
Trying to keep dynamic imports as a single unit (#2288) and not allowing comments to be attached to dynamic imports (#2748) was causing weird behavior when comments existed on a different line than the argument. This often comes up when using webpack's magic comments.
I also removed
tests/import_then/
in favor of the existingtests/dynamic_import/
.Note: this is still an issue for
require
anddefine
, but I imagine multiline comments are much less popular in those methods.CHANGELOG.unreleased.md
file following the template.✨Try the playground for this PR✨