Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Link to fast-glob instead of glob in docs (#6333)" #6721

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

fisker
Copy link
Member

@fisker fisker commented Oct 28, 2019

Revert #6333, fixes #6719

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker changed the title Revert #6333 Revert "Link to fast-glob instead of glob in docs (#6333)" Oct 28, 2019
@brodybits
Copy link
Contributor

After another look at PR #6333, I am not 100% convinced reverting it is 100% what we want.

The point of PR #6333 is that the document referred to the glob syntax from node-glob, while we are now using whatever glob syntax is supported by globby.

I think we also do not want to point to the README on the master branch of the globby project, since its readme now refers to fast-glob.

I wonder if we should point to something like https://github.com/sindresorhus/globby/blob/v6.1.0/readme.md#globbing-patterns until we are ready to use globby@10.

Or maybe it is time to stop supporting old installations (Node.js 6 from GitHub) and use globby@latest?

Food for thought.

@lydell lydell merged commit 545a712 into prettier:master Nov 2, 2019
@fisker fisker deleted the revert-6333 branch November 2, 2019 09:23
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 31, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this PR need revert
3 participants