Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: get rid of webpack #8314

Merged
merged 11 commits into from
Nov 10, 2020
Merged

Build: get rid of webpack #8314

merged 11 commits into from
Nov 10, 2020

Conversation

fisker
Copy link
Member

@fisker fisker commented May 15, 2020 •
edited

Looks like postcss can be bundled by rollup now.

✨Try the playground for this PR✨

@fisker
Copy link
Member Author

fisker commented May 15, 2020 •
edited

circular dependency still not handle correctly by rollup, but better, just one class is wrong, closing for now. Actually maybe it's babel bug.

@fisker fisker closed this May 15, 2020
@alexander-akait
Copy link
Member

@fisker rollup violate spec in many cases, I do not advertise webpack, but I would advise migrate on webpack in future and avoid rollup

@fisker
Copy link
Member Author

fisker commented May 15, 2020

I normally use rollup for library, and webpack for app.

I don't have strong opinion, I just try to avoid use two tools.

@sosukesuzuki
Copy link
Member

@evilebottnawi Out of curiosity, could you tell me how does Rollup violate the spec?

@prettier prettier deleted a comment from ljharb May 18, 2020
dependabot bot and others added 6 commits October 23, 2020 14:00
@dependabot
Build(deps): Bump postcss-less from 3.1.4 to 4.0.0
09f8f92 
Bumps [postcss-less](https://github.com/shellscape/postcss-less) from 3.1.4 to 4.0.0.
- [Release notes](https://github.com/shellscape/postcss-less/releases)
- [Commits](shellscape/postcss-less@v3.1.4...v4.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
@fisker
Fix less parse
3cd96a1
@fisker
Fix tests
07d5728
@fisker
Another test
efa9015
@fisker
Update snapshot
f0fbc05
@fisker
Merge branch 'dependabot/npm_and_yarn/postcss-less-4.0.0' into remove…
983de17 
…-webpack

# Conflicts:
#	package.json
#	scripts/build/build.js
#	scripts/build/bundler.js
#	scripts/build/config.js
#	yarn.lock
@fisker fisker reopened this Oct 23, 2020
@fisker
Copy link
Member Author

fisker commented Oct 23, 2020

As expected, after upgrade postcss to v8 #9471, we can remove webpack now.

@alexander-akait
Copy link
Member

rollup plugins are very buggy and slow, not sure it is good idea

@fisker fisker marked this pull request as ready for review October 26, 2020 03:00
@fisker
Copy link
Member Author

fisker commented Oct 26, 2020

We used rollup to bundle all files except parser-postcss.js. Having two tools makes the build script hard to maintain.

Let's remove it and only use rollup for now, we can switch to webpack completely if it's necessary, or we could try other tools like esbuild too.

@fisker
Merge branch 'master' into remove-webpack
9763623 
# Conflicts:
#	package.json
#	yarn.lock
@fisker
Copy link
Member Author

fisker commented Oct 28, 2020

Merge after #9482

@fisker fisker changed the base branch from master to next November 3, 2020 06:57
@fisker
Merge branch 'next' into remove-webpack
8ca5cb7 
# Conflicts:
#	package.json
#	yarn.lock
@fisker fisker merged commit e9fc39e into prettier:next Nov 10, 2020
@fisker fisker deleted the remove-webpack branch November 10, 2020 01:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thorn0 thorn0 thorn0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fisker @alexander-akait @sosukesuzuki @thorn0