Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix common util import #8696

Merged
merged 2 commits into from Jul 4, 2020
Merged

Fix common util import #8696

merged 2 commits into from Jul 4, 2020

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Jul 2, 2020 •
edited

  • Use destructuring require.
  • Remove import from common/util-shared.js
  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review July 2, 2020 15:30
@fisker fisker changed the title Fix util import Fix common util import Jul 2, 2020
@fisker fisker merged commit 350f641 into prettier:master Jul 4, 2020
@fisker fisker deleted the destructuring-utils branch July 4, 2020 16:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lydell lydell lydell approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fisker @lydell @alexander-akait @sosukesuzuki