Expand first argument if it is an inline function

[Royce]

Addresses #888

setInterval(function() {
  thing();
}, 500);

No longer produces.

setInterval(
  function() {
    thing();
  },
  500
);

[vjeux]

The examples look really good to me, cc @robarnold who wanted this as well.

[vjeux]

you need to check that there is at least one argument, otherwise it's going to throw an exception Cannot read property 'type' of undefined

[vjeux]

👍

[vjeux]

it looks like this part is the only difference. Could you try to merge the two instead of copy pasting everything?

Something like that (feel free to find better variable names:

const groupFirst = shouldGroupFirst()
const groupLast = shouldGroupLast()

if (groupFirst || groupLast) {
  const begin = groupFirst ? printed[0] : printed.slice(0, -1);
  const end = groupFirst ? printed.slice(1) : util.getLast(printed);

  // ...
}

[Royce]

@vjeux Thanks for the prompt feedback. I've updated the PR

[vjeux]

Thanks, the code looks good to me. Next step is to wait for @jlongster to decide if we want to add this behavior or not :)

[jlongster]

My gut tells me not to do this. It's just getting too specific. At some point we have to draw the line and say we aren't going to specialize any more patterns because it makes it too easy to become inconsistent.

Once you starting adding more params or doing more things it becomes unreadable:

setInterval(function() {
  thing();
}, short ? 200 : 500);

func(function() {
  thing();
}, { param: " foo" });

All of these are much better to expand all of the arguments. We shouldn't violate that rule too much. I think the above code looks weird to you only because you are used to see setTimeout specifically formatted that way. Once you use prettier for a while and expect it to break arguments if they span multiple lines, the output is expected and imho a lot more consistent with the rest of the program.

[Royce]

I see your point. Thanks for your time, James, and for a great program :)

[rhengles]

@Royce Implemented in arijs@8d18e1a as groupFirstArg option

[jlongster]

@Royce I think I might be OK with this if it's a lot more strict. Only do it if there are only 2 parameters and the second one is "primitive", meaning it's a literal or an identifier. I tend to resist adding a lot more heuristics but the fact is prettier is really nice because of these kinds of heuristics.

If want to re-open a PR with those changes, I think we can merge it.

[Royce]

@jlongster Please see #947 for a stricter heuristic for grouping first arg. :)