Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix absolute path in custom CSS url() calls #9966

Merged
merged 1 commit into from Dec 28, 2020
Merged

Fix absolute path in custom CSS url() calls #9966

merged 1 commit into from Dec 28, 2020

Commits on Dec 28, 2020

  1. Fix absolute path in custom CSS url() calls 

    At Facebook we have some custom pre-processor `-fb-url(/abs/path/)` that gets messed up as `-fb-url(/ abs/path)`  with the current version of prettier.

The parser has hardcoded logic to only parse as path things that use `url()` but not `-fb-url()` and it parses it as `division /` and `abs/path/`. Because we put a space after division, the bug is introduced.

I don't really know the impact of changing the parser, but on the printer side, it is straightforward to not add a space after `/` if it's the first element in a group. I can't think of any reason why you could write `(/ something` in CSS so I think it's a safe change.
    @vjeux
    vjeux committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    8224e60 View commit details
    Browse the repository at this point in the history