Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support prettier v3 #182

Merged
merged 7 commits into from
Jan 17, 2024
Merged

feat!: support prettier v3 #182

merged 7 commits into from
Jan 17, 2024

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jan 17, 2024

close #164

Waiting #180 (comment)

cc @SukkaW

@JounQin JounQin added enhancement New feature or request dependencies Pull requests that update a dependency file BREAKING labels Jan 17, 2024
@JounQin JounQin self-assigned this Jan 17, 2024
Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: 7ef9964

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pretty-quick Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Jan 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jan 17, 2024

size-limit report 📦

Path Size
src/index.ts 981 B (+2.73% 🔺)

@JounQin JounQin changed the title feat: support prettier v3 feat!: support prettier v3 Jan 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5055759) 85.45% compared to head (7ef9964) 86.04%.

Files Patch % Lines
src/processFiles.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   85.45%   86.04%   +0.59%     
==========================================
  Files           8        9       +1     
  Lines         165      172       +7     
  Branches       49       41       -8     
==========================================
+ Hits          141      148       +7     
  Misses         21       21              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SukkaW
Copy link
Contributor

SukkaW commented Jan 17, 2024

@JounQin What about bumping the minimum Node.js version as well? Currently pretty-quick supports Node.js >= 10.

@JounQin
Copy link
Member Author

JounQin commented Jan 17, 2024

@JounQin What about bumping the minimum Node.js version as well? Currently pretty-quick supports Node.js >= 10.

I've already bumped to >=14.8.0 for top level await. See also https://github.com/prettier/pretty-quick/pull/182/files#diff-795f9cd3f5b7c419d737cc16d57e6c86dac57b1e2656da6d436645bdbd264fc6R15

(But Should we do this? Or keep >=14 same as prettier)

https://github.com/prettier/pretty-quick/pull/182/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R13


I decided to support >=14 because the efforts are just small.

package.json Outdated Show resolved Hide resolved
@JounQin JounQin merged commit f1cacb2 into master Jan 17, 2024
10 checks passed
@JounQin JounQin deleted the feat/prettier_v3 branch January 17, 2024 09:12
@taylorkline
Copy link

Should prettier/prettier#15337 be reverted and pretty-quick be added back to the docs of pre-commit solutions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pretty-quick will break with prettier v3
4 participants